summaryrefslogtreecommitdiff
path: root/docs/bugs_and_glitches.md
diff options
context:
space:
mode:
authorGriffinR <griffin.g.richards@gmail.com>2021-01-13 14:22:42 -0500
committerGitHub <noreply@github.com>2021-01-13 14:22:42 -0500
commit29e59c8eef90b5d166cecae0c54f4ecdd8d51333 (patch)
treec97d81ba6b98e0d9a3ed55108f717bc3f6eae9ed /docs/bugs_and_glitches.md
parent707441827ba44ca57d4fd654256e1c795739b826 (diff)
parent9ed413fe8f3c5d43123368db08d90b7f069d14d3 (diff)
Merge pull request #1300 from GriffinRichards/bugfix-clean
Minor BUGFIX changes, remove redundant bug fix descriptions
Diffstat (limited to 'docs/bugs_and_glitches.md')
-rw-r--r--docs/bugs_and_glitches.md66
1 files changed, 1 insertions, 65 deletions
diff --git a/docs/bugs_and_glitches.md b/docs/bugs_and_glitches.md
index 07955ecd5..ce06c1489 100644
--- a/docs/bugs_and_glitches.md
+++ b/docs/bugs_and_glitches.md
@@ -1,7 +1,7 @@
# Bugs and Glitches
-These are known bugs and glitches in the original Pokémon Emerald game: code that clearly does not work as intended, or that only works in limited circumstances but has the possibility to fail or crash. Defining the `BUGFIX` preprocessor variable will fix some of these automatically.
+These are known bugs and glitches in the original Pokémon Emerald game: code that clearly does not work as intended, or that only works in limited circumstances but has the possibility to fail or crash. Defining the `BUGFIX` and `UBFIX` preprocessor variables will fix some of these automatically. `UBFIX` will already be defined for MODERN builds.
Fixes are written in the `diff` format. If you've used Git before, this should look familiar:
@@ -13,55 +13,9 @@ Fixes are written in the `diff` format. If you've used Git before, this should l
## Contents
-- [RNG does not get seeded](#rng-does-not-get-seeded)
- [Scrolling through items in the bag causes the image to flicker](#scrolling-through-items-in-the-bag-causes-the-image-to-flicker)
-## RNG does not get seeded
-
-**Fix:** Add the following function to [src/main.c](https://github.com/pret/pokeemerald/blob/master/src/main.c):
-```diff
-+static void SeedRngWithRtc(void)
-+{
-+ u32 seed = RtcGetMinuteCount();
-+ seed = (seed >> 16) ^ (seed & 0xFFFF);
-+ SeedRng(seed);
-+}
-```
-
-And edit `AgbMain`:
-
-```diff
- ...
- RtcInit();
- CheckForFlashMemory();
- InitMainCallbacks();
- InitMapMusic();
-+ SeedRngWithRtc();
- ClearDma3Requests();
- ...
-```
-
-This restores the code of Ruby/Sapphire.
-
-**Alternate Fix:** Edit the following function in [src/title_screen.c](https://github.com/pret/pokeemerald/blob/master/src/title_screen.c):
-
-```diff
-void CB2_InitTitleScreen(void)
-{
- switch (gMain.state)
- {
- default:
- case 0:
- SetVBlankCallback(NULL);
-+ StartTimer1();
- SetGpuReg(REG_OFFSET_BLDCNT, 0);
- SetGpuReg(REG_OFFSET_BLDALPHA, 0);
- SetGpuReg(REG_OFFSET_BLDY, 0);
- ...
-```
-This matches what FRLG does and obtains the seed differently than RS, independently of the RTC.
-
## Scrolling through items in the bag causes the image to flicker
**Fix:** Add the following function to [src/item_menu_icons.c](https://github.com/pret/pokeemerald/blob/master/src/item_menu_icons.c):
@@ -95,21 +49,3 @@ Then edit `BagMenu_MoveCursorCallback` in [src/item_menu.c](https://github.com/p
if (itemIndex != LIST_CANCEL)
...
```
-
-## Pokémon that have an affine transform as part of their entry animation glitch when going in and out of Poké Balls without a screen transition in between
-
-**Fix:** Edit `sub_817F77C` in [src/pokemon_animation.c](https://github.com/pret/pokeemerald/blob/master/src/pokemon_animation.c#L1028):
-
-```diff
- ...
--#ifdef BUGFIX
- else
- {
- // FIX: Reset these back to normal after they were changed so Poké Ball catch/release
- // animations without a screen transition in between don't break
- sprite->affineAnimPaused = FALSE;
- sprite->affineAnims = gUnknown_082FF694;
- }
--#endif // BUGFIX
-}
-```