summaryrefslogtreecommitdiff
path: root/gflib/sprite.c
diff options
context:
space:
mode:
authorGriffinR <griffin.g.richards@gmail.com>2021-01-04 20:48:58 -0500
committerGitHub <noreply@github.com>2021-01-04 20:48:58 -0500
commit1b2c9d00ca3aad1cc2e6e83d295cb42abe8a4f42 (patch)
treeb6570d4e95d81f6f4fcac35044697c95fb7b3568 /gflib/sprite.c
parent5cf5adf7d725bcd88a4622adb47f865b9cbef420 (diff)
parenta982e6ab8887853eb6d8776485e5b1d80bd0c645 (diff)
Merge pull request #1291 from Sierraffinity/master
Fix/document possible division by zero in ConvertScaleParam
Diffstat (limited to 'gflib/sprite.c')
-rw-r--r--gflib/sprite.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/gflib/sprite.c b/gflib/sprite.c
index c7e3d09a3..2616aeaed 100644
--- a/gflib/sprite.c
+++ b/gflib/sprite.c
@@ -1320,6 +1320,11 @@ void ApplyAffineAnimFrameRelativeAndUpdateMatrix(u8 matrixNum, struct AffineAnim
s16 ConvertScaleParam(s16 scale)
{
s32 val = 0x10000;
+ // UB: possible division by zero
+#ifdef UBFIX
+ if (scale == 0)
+ return 0;
+#endif //UBFIX
return val / scale;
}