summaryrefslogtreecommitdiff
path: root/src/m4a.c
diff options
context:
space:
mode:
authorgAlfonso-bit <83477269+gAlfonso-bit@users.noreply.github.com>2021-05-23 10:56:37 -0400
committerGitHub <noreply@github.com>2021-05-23 09:56:37 -0500
commitff16812f99f62a495975e7cc3c68ede339171765 (patch)
tree17a0d097f84df30c22f7ff1bdf33aee949ff2fff /src/m4a.c
parentffbbc88801de3fc56d0bf5f0af1418ca7cfcfa4f (diff)
UBFix: uninitialized variables in m4a engine and siirtc.c (#1432)
Diffstat (limited to 'src/m4a.c')
-rw-r--r--src/m4a.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/src/m4a.c b/src/m4a.c
index 717cafc78..105312a40 100644
--- a/src/m4a.c
+++ b/src/m4a.c
@@ -1525,6 +1525,10 @@ void ply_xwave(struct MusicPlayerInfo *mplayInfo, struct MusicPlayerTrack *track
{
u32 wav;
+#ifdef UBFIX
+ wav = 0;
+#endif
+
READ_XCMD_BYTE(wav, 0) // UB: uninitialized variable
READ_XCMD_BYTE(wav, 1)
READ_XCMD_BYTE(wav, 2)
@@ -1592,6 +1596,10 @@ void ply_xcmd_0C(struct MusicPlayerInfo *mplayInfo, struct MusicPlayerTrack *tra
{
u32 unk;
+#ifdef UBFIX
+ unk = 0;
+#endif
+
READ_XCMD_BYTE(unk, 0) // UB: uninitialized variable
READ_XCMD_BYTE(unk, 1)
@@ -1611,6 +1619,7 @@ void ply_xcmd_0C(struct MusicPlayerInfo *mplayInfo, struct MusicPlayerTrack *tra
void ply_xcmd_0D(struct MusicPlayerInfo *mplayInfo, struct MusicPlayerTrack *track)
{
u32 unk;
+
#ifdef UBFIX
unk = 0;
#endif