summaryrefslogtreecommitdiff
path: root/src/union_room.c
diff options
context:
space:
mode:
authorExpoSeed <>2021-05-15 15:56:17 -0500
committerExpoSeed <>2021-05-15 15:56:17 -0500
commit361fa594b30005edaa8aef5f6b02ac8b15149cba (patch)
tree24cfa5b11022ac28cccd5634e95bfe1e2ad6040c /src/union_room.c
parentab8318cc79de60413085b104125490cbae344169 (diff)
Various BUGFIXes and UBFIXes
Diffstat (limited to 'src/union_room.c')
-rw-r--r--src/union_room.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/union_room.c b/src/union_room.c
index f41cfd45f..bd6b303b9 100644
--- a/src/union_room.c
+++ b/src/union_room.c
@@ -319,8 +319,13 @@ static void StringExpandPlaceholders_AwaitingCommFromAnother(u8 *dst, u8 caseId)
case ACTIVITY_CONTEST_CUTE:
case ACTIVITY_CONTEST_SMART:
case ACTIVITY_CONTEST_TOUGH:
- // UB: argument *dst isn't used, instead it always prints to gStringVar4
+ // BUG: argument *dst isn't used, instead it always prints to gStringVar4
+ // not an issue in practice since Gamefreak never used any other arguments here besides gStringVar4
+ #ifndef BUGFIX
StringExpandPlaceholders(gStringVar4, sText_AwaitingCommunication);
+ #else
+ StringExpandPlaceholders(dst, sText_AwaitingCommunication);
+ #endif
break;
}
}