summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorPokeCodec <67983839+PokeCodec@users.noreply.github.com>2020-09-05 10:01:21 -0400
committerPokeCodec <67983839+PokeCodec@users.noreply.github.com>2020-09-05 10:01:21 -0400
commit3e25d9e5a2e0346a53b1bfdf9e14f98e14cceb21 (patch)
tree995eed5e53b8faf2088066744281a8f34517c07e /src
parentde274dcb078f15d4c4266444c63c4629071b130a (diff)
Removed unused parentheses
Diffstat (limited to 'src')
-rw-r--r--src/easy_chat.c10
-rwxr-xr-xsrc/item_menu.c6
-rw-r--r--src/pokedex.c18
-rw-r--r--src/pokemon_summary_screen.c4
-rw-r--r--src/pokenav_conditions_3.c13
5 files changed, 25 insertions, 26 deletions
diff --git a/src/easy_chat.c b/src/easy_chat.c
index 0ec4d32fd..e08f0bb75 100644
--- a/src/easy_chat.c
+++ b/src/easy_chat.c
@@ -1614,26 +1614,26 @@ static u16 sub_811ACDC(void)
{
return sub_811B150();
}
- else if (JOY_NEW(START_BUTTON))
+ if (JOY_NEW(START_BUTTON))
{
return sub_811B1B4();
}
- else if (JOY_NEW(DPAD_UP))
+ if (JOY_NEW(DPAD_UP))
{
sEasyChatScreen->mainCursorRow--;
break;
}
- else if (JOY_NEW(DPAD_LEFT))
+ if (JOY_NEW(DPAD_LEFT))
{
sEasyChatScreen->mainCursorColumn--;
break;
}
- else if (JOY_NEW(DPAD_DOWN))
+ if (JOY_NEW(DPAD_DOWN))
{
sEasyChatScreen->mainCursorRow = 0;
break;
}
- else if (JOY_NEW(DPAD_RIGHT))
+ if (JOY_NEW(DPAD_RIGHT))
{
sEasyChatScreen->mainCursorColumn++;
break;
diff --git a/src/item_menu.c b/src/item_menu.c
index e1ab5d0fa..1d74210c7 100755
--- a/src/item_menu.c
+++ b/src/item_menu.c
@@ -1229,12 +1229,12 @@ static u8 GetSwitchBagPocketDirection(void)
if (gBagMenu->pocketSwitchDisabled)
return SWITCH_POCKET_NONE;
LRKeys = GetLRKeysPressed();
- if ((JOY_NEW(DPAD_LEFT)) || LRKeys == MENU_L_PRESSED)
+ if (JOY_NEW(DPAD_LEFT) || LRKeys == MENU_L_PRESSED)
{
PlaySE(SE_SELECT);
return SWITCH_POCKET_LEFT;
}
- if ((JOY_NEW(DPAD_RIGHT)) || LRKeys == MENU_R_PRESSED)
+ if (JOY_NEW(DPAD_RIGHT) || LRKeys == MENU_R_PRESSED)
{
PlaySE(SE_SELECT);
return SWITCH_POCKET_RIGHT;
@@ -1669,7 +1669,7 @@ void Task_HandleOutOfBattleItemMenuInput(u8 taskId)
ChangeListMenuCursorPosition(MENU_CURSOR_DELTA_LEFT, MENU_CURSOR_DELTA_NONE);
}
}
- else if ((JOY_NEW(DPAD_RIGHT)) || GetLRKeysPressed() == MENU_R_PRESSED)
+ else if (JOY_NEW(DPAD_RIGHT) || GetLRKeysPressed() == MENU_R_PRESSED)
{
if (!(cursorPos & 1) && sub_81ACDFC(cursorPos + 1))
{
diff --git a/src/pokedex.c b/src/pokedex.c
index e21048ce6..e49911891 100644
--- a/src/pokedex.c
+++ b/src/pokedex.c
@@ -2598,7 +2598,7 @@ static u16 TryDoPokedexScroll(u16 selectedMon, u16 ignored)
CreateMonListEntry(1, selectedMon, ignored);
PlaySE(SE_DEX_SCROLL);
}
- else if ((JOY_HELD(DPAD_DOWN)) && (selectedMon < sPokedexView->pokemonListCount - 1))
+ else if (JOY_HELD(DPAD_DOWN) && (selectedMon < sPokedexView->pokemonListCount - 1))
{
scrollDir = 2;
selectedMon = GetNextPosition(0, selectedMon, 0, sPokedexView->pokemonListCount - 1);
@@ -2606,7 +2606,7 @@ static u16 TryDoPokedexScroll(u16 selectedMon, u16 ignored)
CreateMonListEntry(2, selectedMon, ignored);
PlaySE(SE_DEX_SCROLL);
}
- else if ((JOY_NEW(DPAD_LEFT)) && (selectedMon > 0))
+ else if (JOY_NEW(DPAD_LEFT) && (selectedMon > 0))
{
startingPos = selectedMon;
@@ -3400,8 +3400,8 @@ static void Task_HandleInfoScreenInput(u8 taskId)
}
return;
}
- if (((JOY_NEW(DPAD_LEFT))
- || ((JOY_NEW(L_BUTTON)) && gSaveBlock2Ptr->optionsButtonMode == OPTIONS_BUTTON_MODE_LR))
+ if ((JOY_NEW(DPAD_LEFT)
+ || (JOY_NEW(L_BUTTON) && gSaveBlock2Ptr->optionsButtonMode == OPTIONS_BUTTON_MODE_LR))
&& sPokedexView->selectedScreen > 0)
{
sPokedexView->selectedScreen--;
@@ -3409,8 +3409,8 @@ static void Task_HandleInfoScreenInput(u8 taskId)
PlaySE(SE_DEX_PAGE);
return;
}
- if (((JOY_NEW(DPAD_RIGHT))
- || ((JOY_NEW(R_BUTTON)) && gSaveBlock2Ptr->optionsButtonMode == OPTIONS_BUTTON_MODE_LR))
+ if ((JOY_NEW(DPAD_RIGHT)
+ || (JOY_NEW(R_BUTTON) && gSaveBlock2Ptr->optionsButtonMode == OPTIONS_BUTTON_MODE_LR))
&& sPokedexView->selectedScreen < CANCEL_SCREEN)
{
sPokedexView->selectedScreen++;
@@ -3657,8 +3657,8 @@ static void Task_HandleCryScreenInput(u8 taskId)
PlaySE(SE_DEX_PAGE);
return;
}
- if ((JOY_NEW(DPAD_RIGHT))
- || ((JOY_NEW(R_BUTTON)) && gSaveBlock2Ptr->optionsButtonMode == OPTIONS_BUTTON_MODE_LR))
+ if (JOY_NEW(DPAD_RIGHT)
+ || (JOY_NEW(R_BUTTON) && gSaveBlock2Ptr->optionsButtonMode == OPTIONS_BUTTON_MODE_LR))
{
if (!sPokedexListItem->owned)
{
@@ -5031,7 +5031,7 @@ static void Task_HandleSearchMenuInput(u8 taskId)
CopyWindowToVram(0, 2);
CopyBgTilemapBufferToVram(3);
}
- if ((JOY_NEW(DPAD_RIGHT)) && movementMap[gTasks[taskId].tMenuItem][1] != 0xFF)
+ if (JOY_NEW(DPAD_RIGHT) && movementMap[gTasks[taskId].tMenuItem][1] != 0xFF)
{
PlaySE(SE_SELECT);
gTasks[taskId].tMenuItem = movementMap[gTasks[taskId].tMenuItem][1];
diff --git a/src/pokemon_summary_screen.c b/src/pokemon_summary_screen.c
index 9b8e4ef9e..bfd849229 100644
--- a/src/pokemon_summary_screen.c
+++ b/src/pokemon_summary_screen.c
@@ -1505,11 +1505,11 @@ static void Task_HandleInput(u8 taskId)
{
ChangeSummaryPokemon(taskId, 1);
}
- else if ((JOY_NEW(DPAD_LEFT)) || GetLRKeysPressed() == MENU_L_PRESSED)
+ else if (JOY_NEW(DPAD_LEFT) || GetLRKeysPressed() == MENU_L_PRESSED)
{
ChangePage(taskId, -1);
}
- else if ((JOY_NEW(DPAD_RIGHT)) || GetLRKeysPressed() == MENU_R_PRESSED)
+ else if (JOY_NEW(DPAD_RIGHT) || GetLRKeysPressed() == MENU_R_PRESSED)
{
ChangePage(taskId, 1);
}
diff --git a/src/pokenav_conditions_3.c b/src/pokenav_conditions_3.c
index 0c1fb08d2..15b687a42 100644
--- a/src/pokenav_conditions_3.c
+++ b/src/pokenav_conditions_3.c
@@ -172,27 +172,26 @@ static u32 sub_81CF030(struct PokenavSub7 *structPtr)
{
if (JOY_REPEAT(DPAD_UP))
return 1;
- else if (JOY_REPEAT(DPAD_DOWN))
+ if (JOY_REPEAT(DPAD_DOWN))
return 2;
- else if (JOY_NEW(DPAD_LEFT))
+ if (JOY_NEW(DPAD_LEFT))
return 3;
- else if (JOY_NEW(DPAD_RIGHT))
+ if (JOY_NEW(DPAD_RIGHT))
return 4;
- else if (JOY_NEW(B_BUTTON))
+ if (JOY_NEW(B_BUTTON))
{
structPtr->unk1C = 0;
structPtr->unk0 = sub_81CF0B0;
return 5;
}
- else if (JOY_NEW(A_BUTTON))
+ if (JOY_NEW(A_BUTTON))
{
structPtr->unkPtr->unk2 = GetSelectedMatchCall();
structPtr->unk1C = 1;
structPtr->unk0 = sub_81CF0B8;
return 6;
}
- else
- return 0;
+ return 0;
}
static u32 sub_81CF0B0(struct PokenavSub7 *structPtr)