diff options
| author | kiliwily <69381603+kiliwily@users.noreply.github.com> | 2020-09-12 18:43:20 +0200 |
|---|---|---|
| committer | kiliwily <69381603+kiliwily@users.noreply.github.com> | 2020-09-12 18:43:20 +0200 |
| commit | 5c3669e0cd49ccc210d7c57228820685fef11230 (patch) | |
| tree | e35581dc740febcc9049b442a9059a0e6e38fadb /src | |
| parent | 58a2b62bae1406d2c768698ed13efcd6a5ffbeec (diff) | |
Bug documenting
Diffstat (limited to 'src')
| -rw-r--r-- | src/battle_util.c | 2 | ||||
| -rw-r--r-- | src/metatile_behavior.c | 4 | ||||
| -rw-r--r-- | src/pokemon.c | 2 |
3 files changed, 8 insertions, 0 deletions
diff --git a/src/battle_util.c b/src/battle_util.c index eb3907157..0c2e31e07 100644 --- a/src/battle_util.c +++ b/src/battle_util.c @@ -527,6 +527,8 @@ void HandleAction_ThrowPokeblock(void) gBattleStruct->safariPkblThrowCounter++; if (gBattleStruct->safariEscapeFactor > 1) { + //BUG: The safariEscapeFactor is unintetionally able to become 0 (but it can not become negative!). This causes the pokeblock throw glitch. + //To fix that change the < in the if statement below to <=. if (gBattleStruct->safariEscapeFactor < sPkblToEscapeFactor[gBattleStruct->safariPkblThrowCounter][gBattleCommunication[MULTISTRING_CHOOSER]]) gBattleStruct->safariEscapeFactor = 1; else diff --git a/src/metatile_behavior.c b/src/metatile_behavior.c index dde4de329..516a44a07 100644 --- a/src/metatile_behavior.c +++ b/src/metatile_behavior.c @@ -968,6 +968,10 @@ bool8 MetatileBehavior_IsDiveable(u8 metatileBehavior) bool8 MetatileBehavior_IsUnableToEmerge(u8 metatileBehavior) { + //BUG: The player is unintentionally able to emerge on water doors. + //Also the narrower underwater door in the underwater tileset has the wrong metatile behavior. This causes the dive glitch. + //To fix that add ||metatileBehavior == MB_WATER_DOOR to the if statement below and + //change the metatile behavior of the narrower water door with porymaps tilset editor. if (metatileBehavior == MB_NO_SURFACING || metatileBehavior == MB_SEAWEED_NO_SURFACING) return TRUE; diff --git a/src/pokemon.c b/src/pokemon.c index a0e655d1e..f706e8ef8 100644 --- a/src/pokemon.c +++ b/src/pokemon.c @@ -2861,6 +2861,8 @@ void CalculateMonStats(struct Pokemon *mon) if (currentHP == 0 && oldMaxHP == 0) currentHP = newMaxHP; else if (currentHP != 0) + //BUG: currentHP is unintentionally able to become <= 0 after the instruction below. This causes the pomeg berry glitch. + //To fix this add another if statement after the instruction that desides what happens if currentHP <= 0. currentHP += newMaxHP - oldMaxHP; else return; |