Age | Commit message (Collapse) | Author | |
---|---|---|---|
2021-03-12 | Resolve link comm buffers in gBattleStruct | PikalaxALT | |
2021-03-12 | Fix Son/Daughter name swap | GriffinR | |
2021-03-10 | Use GENDER_COUNT Constants & Rename an Unknown in field_player_avatar.c | Deokishisu | |
`gUnknown_835B882` has been cleaned up and renamed to `sPlayerAvatarGfxToStateFlag` to match pokeemerald. | |||
2021-03-10 | Fix Typos / Use Box Constants | Deokishisu | |
The Celadon City scripts that give Eevee misspelled it as Eeevee. Fixed. The comment explaining `boxRSEggsUnlocked` in the `ExternalEventFlags` struct had an incorrect deposit requirement listed and was fixed. Also, replaced the literals with the `TOTAL_BOXES_COUNT` and `IN_BOX_COUNT` constants in `pokemon.c`'s `IsPokemonStorageFull` function. Thanks hjk321 for pointing that out. | |||
2021-02-22 | Merge pull request #396 from hjk321/storage-magic | GriffinR | |
Change embarassing magic numbers that should have been fixed a long time ago | |||
2021-02-22 | Fix storage magic numbers | hjk321 | |
I could *kinda* understand missing SendMonToPc, but IN THE STRUCT ITSELF?! | |||
2021-02-19 | Merge pull request #393 from Kurausukun/text_printer | GriffinR | |
[LEAK-INFORMED] match rest of text_printer | |||
2021-02-19 | oops forgot one | Kurausukun | |
2021-02-19 | remove redundant parentheses | Kurausukun | |
2021-02-16 | Mirror pokeemerald PR#1329 & PR#1335 to pokefirered | Deokishisu | |
The `giftRibbons` field in `SaveBlock1` has been split out into proper subfields. The new ExternalEvent structs deal with interconnectivity between external games/peripherals and FRLG. US & JP Colosseum Bonus Discs', Colosseum and XD's, Pokémon Channel's, and PokémonBox: Ruby & Sapphire's interactions with these fields has been documented. The `giftRibbon#` fields in `PokemonSubstruct3` have also been renamed to their appropriate ribbons, and commented with distribution info if applicable. The previous `fatefulEncounter` field was actually filler, and relabeled as such, while the `obedient` bit was renamed `eventLegal`. All relevant constants and functions dealing with the Pokémon data structure were renamed with these changes in mind. I still maintain that `eventLegal` is a misnomer and it should be called `fatefulEncounter` in all three repos. | |||
2021-02-16 | [LEAK-INFORMED] match rest of text_printer | Kurausukun | |
2021-02-14 | Rename "Hidden" Movement Type to "Buried" | Deokishisu | |
This commit mirrors the change to pokeemerald that renames `MOVEMENT_TYPE_HIDDEN` to `MOVEMENT_TYPE_BURIED` to avoid confusion between it and `MOVEMENT_TYPE_INVISIBLE`. As the files and function labels are not synced between the two repos, only the necessary changes were made based on what pokefirered calls its functions. More syncing of labels with pokeemerald will need to be done in the future. | |||
2021-02-14 | Merge pull request #388 from GriffinRichards/constants-localids | GriffinR | |
Use more LOCALID constants | |||
2021-02-14 | Merge pull request #389 from Kurausukun/dexmatching | GriffinR | |
[LEAK-INFORMED] match the rest of pokedex_screen | |||
2021-02-12 | Fix warning about gMonPaletteTable section | GriffinR | |
2021-02-11 | words are hard | Kurausukun | |
2021-02-11 | fix whitespace, update dex category macro | Kurausukun | |
2021-02-11 | [LEAK-INFORMED] match the rest of pokedex_screen | Kurausukun | |
2021-02-10 | Use more LOCALID constants | GriffinR | |
2021-02-09 | Fix Trainer Tower Magic Number | Deokishisu | |
A magic number was missed that will lead to edited projects breaking the Trainer Tower if new map layouts are added. This commit fixes it. | |||
2021-02-05 | Fix "Compatibility" Misspelling | Deokishisu | |
Someone misspelled "compatibility" as "compatability" in pokeemerald and the error was brought over to pokefirered. | |||
2021-01-29 | Use trainer constants in flags, automatically update flags/vars count | GriffinR | |
2021-01-19 | Move 'source' asm files to src | GriffinR | |
2021-01-08 | Fix Egregious Magic Numbers in GetBattleBGM | Deokishisu | |
Whoever originally decomped this function must've been really fed up with this file. Renamed GetMUS_ForBattle to GetBattleBGM to be consistent with pokeemerald. This entire function was magic numbers, so I replaced them with the appropriate constants. | |||
2021-01-01 | Document the unused battle strings for downpour and rain weather | SatoMew | |
2020-12-31 | Fix Missed Magic Numbers in main_menu.c | Deokishisu | |
There were two lines where magic numbers were used instead of the constant for MAIN_MENU_WINDOW_ERROR, so I filled them in. | |||
2020-11-27 | Merge pull request #371 from GriffinRichards/data-pokedex | GriffinR | |
Move pokedex_screen data from asm to C | |||
2020-11-26 | Rename farfetchd graphics to match define | Ashley Coleman | |
2020-11-12 | Rename unknown trainer party variables | Ashley Coleman | |
2020-11-12 | Fix modern build | GriffinR | |
2020-11-12 | Clean up pokedex screen text | GriffinR | |
2020-11-11 | Move pokedex_screen data from asm to C | GriffinR | |
2020-11-01 | Match FadeOutBody (ported from pokeemerald) | Kurausukun | |
2020-10-11 | Fix hang when releasing after adding new moves | GriffinR | |
2020-09-08 | Match sub_8159AB8 | PikalaxALT | |
2020-09-06 | Add "MAP_" prefix missing from 76e126a35b00ecf87038c37de1899cd923617e45 | BigBahss | |
2020-09-06 | Add "MAP_" prefix to LeafGreen "map" fields | BigBahss | |
2020-09-03 | Fix agb_flash in modern frlg | PikalaxALT | |
2020-09-02 | fix wrong file names | tianmaru | |
2020-09-02 | renamed title screen sprites | tianmaru | |
2020-09-01 | Match Most of Remaining Functions | PokeCodec | |
2020-08-29 | Give songs meaningful english names | GriffinR | |
2020-08-18 | Wrap asm statements in NONMATCHING | GriffinR | |
2020-08-17 | Match sub_80D1F64 | PokeCodec | |
2020-07-10 | Bugfix for access violation in MapPreview_CreateMapNameWindow | PikalaxALT | |
2020-07-08 | Fix sub_8137C18 nonmatching. | luckytyphlosion | |
2020-07-04 | Apply static modifier to static functions in PSS. | luckytyphlosion | |
2020-07-04 | Fix prefixes of static variables in PSS. | luckytyphlosion | |
2020-07-04 | Declare some data as static. | luckytyphlosion | |
2020-07-04 | Port over PSS data to src. | luckytyphlosion | |