summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2021-03-12Resolve link comm buffers in gBattleStructPikalaxALT
2021-03-12Fix Son/Daughter name swapGriffinR
2021-03-10Use GENDER_COUNT Constants & Rename an Unknown in field_player_avatar.cDeokishisu
`gUnknown_835B882` has been cleaned up and renamed to `sPlayerAvatarGfxToStateFlag` to match pokeemerald.
2021-03-10Fix Typos / Use Box ConstantsDeokishisu
The Celadon City scripts that give Eevee misspelled it as Eeevee. Fixed. The comment explaining `boxRSEggsUnlocked` in the `ExternalEventFlags` struct had an incorrect deposit requirement listed and was fixed. Also, replaced the literals with the `TOTAL_BOXES_COUNT` and `IN_BOX_COUNT` constants in `pokemon.c`'s `IsPokemonStorageFull` function. Thanks hjk321 for pointing that out.
2021-02-22Merge pull request #396 from hjk321/storage-magicGriffinR
Change embarassing magic numbers that should have been fixed a long time ago
2021-02-22Fix storage magic numbershjk321
I could *kinda* understand missing SendMonToPc, but IN THE STRUCT ITSELF?!
2021-02-19Merge pull request #393 from Kurausukun/text_printerGriffinR
[LEAK-INFORMED] match rest of text_printer
2021-02-19oops forgot oneKurausukun
2021-02-19remove redundant parenthesesKurausukun
2021-02-16Mirror pokeemerald PR#1329 & PR#1335 to pokefireredDeokishisu
The `giftRibbons` field in `SaveBlock1` has been split out into proper subfields. The new ExternalEvent structs deal with interconnectivity between external games/peripherals and FRLG. US & JP Colosseum Bonus Discs', Colosseum and XD's, Pokémon Channel's, and PokémonBox: Ruby & Sapphire's interactions with these fields has been documented. The `giftRibbon#` fields in `PokemonSubstruct3` have also been renamed to their appropriate ribbons, and commented with distribution info if applicable. The previous `fatefulEncounter` field was actually filler, and relabeled as such, while the `obedient` bit was renamed `eventLegal`. All relevant constants and functions dealing with the Pokémon data structure were renamed with these changes in mind. I still maintain that `eventLegal` is a misnomer and it should be called `fatefulEncounter` in all three repos.
2021-02-16[LEAK-INFORMED] match rest of text_printerKurausukun
2021-02-14Rename "Hidden" Movement Type to "Buried"Deokishisu
This commit mirrors the change to pokeemerald that renames `MOVEMENT_TYPE_HIDDEN` to `MOVEMENT_TYPE_BURIED` to avoid confusion between it and `MOVEMENT_TYPE_INVISIBLE`. As the files and function labels are not synced between the two repos, only the necessary changes were made based on what pokefirered calls its functions. More syncing of labels with pokeemerald will need to be done in the future.
2021-02-14Merge pull request #388 from GriffinRichards/constants-localidsGriffinR
Use more LOCALID constants
2021-02-14Merge pull request #389 from Kurausukun/dexmatchingGriffinR
[LEAK-INFORMED] match the rest of pokedex_screen
2021-02-12Fix warning about gMonPaletteTable sectionGriffinR
2021-02-11words are hardKurausukun
2021-02-11fix whitespace, update dex category macroKurausukun
2021-02-11[LEAK-INFORMED] match the rest of pokedex_screenKurausukun
2021-02-10Use more LOCALID constantsGriffinR
2021-02-09Fix Trainer Tower Magic NumberDeokishisu
A magic number was missed that will lead to edited projects breaking the Trainer Tower if new map layouts are added. This commit fixes it.
2021-02-05Fix "Compatibility" MisspellingDeokishisu
Someone misspelled "compatibility" as "compatability" in pokeemerald and the error was brought over to pokefirered.
2021-01-29Use trainer constants in flags, automatically update flags/vars countGriffinR
2021-01-19Move 'source' asm files to srcGriffinR
2021-01-08Fix Egregious Magic Numbers in GetBattleBGMDeokishisu
Whoever originally decomped this function must've been really fed up with this file. Renamed GetMUS_ForBattle to GetBattleBGM to be consistent with pokeemerald. This entire function was magic numbers, so I replaced them with the appropriate constants.
2021-01-01Document the unused battle strings for downpour and rain weatherSatoMew
2020-12-31Fix Missed Magic Numbers in main_menu.cDeokishisu
There were two lines where magic numbers were used instead of the constant for MAIN_MENU_WINDOW_ERROR, so I filled them in.
2020-11-27Merge pull request #371 from GriffinRichards/data-pokedexGriffinR
Move pokedex_screen data from asm to C
2020-11-26Rename farfetchd graphics to match defineAshley Coleman
2020-11-12Rename unknown trainer party variablesAshley Coleman
2020-11-12Fix modern buildGriffinR
2020-11-12Clean up pokedex screen textGriffinR
2020-11-11Move pokedex_screen data from asm to CGriffinR
2020-11-01Match FadeOutBody (ported from pokeemerald)Kurausukun
2020-10-11Fix hang when releasing after adding new movesGriffinR
2020-09-08Match sub_8159AB8PikalaxALT
2020-09-06Add "MAP_" prefix missing from 76e126a35b00ecf87038c37de1899cd923617e45BigBahss
2020-09-06Add "MAP_" prefix to LeafGreen "map" fieldsBigBahss
2020-09-03Fix agb_flash in modern frlgPikalaxALT
2020-09-02fix wrong file namestianmaru
2020-09-02renamed title screen spritestianmaru
2020-09-01Match Most of Remaining FunctionsPokeCodec
2020-08-29Give songs meaningful english namesGriffinR
2020-08-18Wrap asm statements in NONMATCHINGGriffinR
2020-08-17Match sub_80D1F64PokeCodec
2020-07-10Bugfix for access violation in MapPreview_CreateMapNameWindowPikalaxALT
2020-07-08Fix sub_8137C18 nonmatching.luckytyphlosion
2020-07-04Apply static modifier to static functions in PSS.luckytyphlosion
2020-07-04Fix prefixes of static variables in PSS.luckytyphlosion
2020-07-04Declare some data as static.luckytyphlosion
2020-07-04Port over PSS data to src.luckytyphlosion