summaryrefslogtreecommitdiff
path: root/engine
diff options
context:
space:
mode:
authorRangi <remy.oukaour+rangi42@gmail.com>2020-11-13 11:10:03 -0500
committerRangi <remy.oukaour+rangi42@gmail.com>2020-11-13 11:10:03 -0500
commitb88572fbccecc8d125fe8a50365751f0530d1a9a (patch)
tree46a733a0ad7259689b9b5577f109751f34f42956 /engine
parent5f8f221bad050e54c150d1c5ca8d827284235091 (diff)
Add constants for player and rival starters
Diffstat (limited to 'engine')
-rw-r--r--engine/debug/debug_party.asm8
-rwxr-xr-xengine/menus/start_sub_menus.asm2
-rwxr-xr-xengine/movie/oak_speech/oak_speech.asm2
-rwxr-xr-xengine/movie/title_rb.asm6
-rwxr-xr-xengine/pikachu/pikachu_emotions.asm2
-rwxr-xr-xengine/pikachu/pikachu_status.asm6
6 files changed, 13 insertions, 13 deletions
diff --git a/engine/debug/debug_party.asm b/engine/debug/debug_party.asm
index 637482eb..67a27710 100644
--- a/engine/debug/debug_party.asm
+++ b/engine/debug/debug_party.asm
@@ -17,7 +17,7 @@ DebugTeam:
db SNORLAX, 80
db PERSIAN, 80
db JIGGLYPUFF, 15
- db PIKACHU, 5
+ db STARTER_PIKACHU, 5
db -1 ; end
DebugStart:
@@ -75,13 +75,13 @@ IF DEF(_DEBUG)
call DebugSetPokedexEntries
SetEvent EVENT_GOT_POKEDEX
- ; Player chose Pikachu.
+ ; Rival chose Jolteon.
ld hl, wRivalStarter
- ld a, 1
+ ld a, RIVAL_STARTER_JOLTEON
ld [hli], a
ld a, NUM_POKEMON
ld [hli], a ; hl = wUnknownDebugByte
- ld a, PIKACHU
+ ld a, STARTER_PIKACHU
ld [hl], a ; hl = wPlayerStarter
; Give max money.
diff --git a/engine/menus/start_sub_menus.asm b/engine/menus/start_sub_menus.asm
index b9751e1e..c054761c 100755
--- a/engine/menus/start_sub_menus.asm
+++ b/engine/menus/start_sub_menus.asm
@@ -169,7 +169,7 @@ StartMenu_Pokemon::
res 1, [hl]
jp z, .loop
ld a, [wcf91]
- cp PIKACHU ; is this surfing pikachu?
+ cp STARTER_PIKACHU
jr z, .surfingPikachu
ld a, $1
jr .continue
diff --git a/engine/movie/oak_speech/oak_speech.asm b/engine/movie/oak_speech/oak_speech.asm
index 1a327def..7acbd693 100755
--- a/engine/movie/oak_speech/oak_speech.asm
+++ b/engine/movie/oak_speech/oak_speech.asm
@@ -72,7 +72,7 @@ OakSpeech:
call PrintText
call GBFadeOutToWhite
call ClearScreen
- ld a, PIKACHU
+ ld a, STARTER_PIKACHU
ld [wd0b5], a
ld [wcf91], a
call GetMonHeader
diff --git a/engine/movie/title_rb.asm b/engine/movie/title_rb.asm
index df630b53..597684df 100755
--- a/engine/movie/title_rb.asm
+++ b/engine/movie/title_rb.asm
@@ -92,11 +92,11 @@ TitleBallYTable:
TitleScreenAnimateBallIfStarterOut:
; Animate the TitleBall if a starter just got scrolled out.
ld a, [wTitleScreenScene]
- cp STARTER1
+ cp CHARMANDER ; starter 1
jr z, .ok
- cp STARTER2
+ cp SQUIRTLE ; starter 2
jr z, .ok
- cp STARTER3
+ cp BULBASAUR ; starter 3
ret nz
.ok
ld e, 1 ; animate titleball
diff --git a/engine/pikachu/pikachu_emotions.asm b/engine/pikachu/pikachu_emotions.asm
index 61db6e80..f4963f17 100755
--- a/engine/pikachu/pikachu_emotions.asm
+++ b/engine/pikachu/pikachu_emotions.asm
@@ -381,7 +381,7 @@ IsPlayerPikachuAsleepInParty:
ld a, [hl]
cp $ff
jr z, .done
- cp PIKACHU
+ cp STARTER_PIKACHU
jr nz, .curMonNotStarterPikachu
callfar IsThisPartymonStarterPikachu
jr nc, .curMonNotStarterPikachu
diff --git a/engine/pikachu/pikachu_status.asm b/engine/pikachu/pikachu_status.asm
index c73d3b3f..5fc92ead 100755
--- a/engine/pikachu/pikachu_status.asm
+++ b/engine/pikachu/pikachu_status.asm
@@ -9,7 +9,7 @@ IsStarterPikachuInOurParty::
push hl
inc a
jr z, .noPlayerPikachu
- cp PIKACHU + 1
+ cp STARTER_PIKACHU + 1
jr nz, .curMonNotPlayerPikachu
ld h, d
ld l, e
@@ -79,7 +79,7 @@ asm_fce21:
ld a, [wWhichPokemon]
call AddNTimes
ld a, [hl]
- cp PIKACHU
+ cp STARTER_PIKACHU
jr nz, .notPlayerPikachu
ld bc, wPartyMon1OTID - wPartyMon1
add hl, bc
@@ -189,7 +189,7 @@ IsSurfingPikachuInThePlayersParty::
push hl
inc a
jr z, .noSurfingPlayerPikachu
- cp PIKACHU+1
+ cp STARTER_PIKACHU + 1
jr nz, .curMonNotSurfingPlayerPikachu
ld h, d
ld l, e