diff options
| author | Rangi <35663410+Rangi42@users.noreply.github.com> | 2020-03-23 21:05:39 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-23 21:05:39 -0400 |
| commit | 63798d56d05cf87ada77bd26727ea7725630b0b2 (patch) | |
| tree | c90b2bebe86dffe78e6597d220f70196d3e69e25 /docs/bugs_and_glitches.md | |
| parent | 624864307e4e7a5055c01d7f06145feec35527a7 (diff) | |
| parent | 0345e4fb0e3f39a038e9eced72380a5a1ab6694f (diff) | |
Merge pull request #699 from Rangi42/master
Resolve some miscellaneous issues
Diffstat (limited to 'docs/bugs_and_glitches.md')
| -rw-r--r-- | docs/bugs_and_glitches.md | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/docs/bugs_and_glitches.md b/docs/bugs_and_glitches.md index abb1e524f..f306cc84d 100644 --- a/docs/bugs_and_glitches.md +++ b/docs/bugs_and_glitches.md @@ -901,8 +901,12 @@ This bug existed for all battles in Gold and Silver, and was only fixed for sing ld hl, wEnemyMonType1 ldh a, [hBattleTurn] and a - jr z, CheckTypeMatchup +- jr z, CheckTypeMatchup ++ jr z, .get_type ld hl, wBattleMonType1 ++.get_type ++ ld a, BATTLE_VARS_MOVE_TYPE ++ call GetBattleVar ; preserves hl, de, and bc CheckTypeMatchup: -; There is an incorrect assumption about this function made in the AI related code: when -; the AI calls CheckTypeMatchup (not BattleCheckTypeMatchup), it assumes that placing the @@ -910,8 +914,6 @@ This bug existed for all battles in Gold and Silver, and was only fixed for sing -; this assumption is incorrect. A simple fix would be to load the move type for the -; current move into a in BattleCheckTypeMatchup, before falling through, which is -; consistent with how the rest of the code assumes this code works like. -+ ld a, BATTLE_VARS_MOVE_TYPE -+ call GetBattleVar ; preserves hl, de, and bc push hl push de push bc @@ -1840,8 +1842,8 @@ This bug can allow you to talk to Eusine in Celadon City and encounter Ho-Oh wit ld hl, wPlayerName --rept NAME_LENGTH_JAPANESE + -2 ; should be PLAYER_NAME_LENGTH + -2 -+rept PLAYER_NAME_LENGTH + -2 +-rept NAME_LENGTH_JAPANESE - 2 ; should be PLAYER_NAME_LENGTH - 2 ++rept PLAYER_NAME_LENGTH - 2 ld a, [de] cp [hl] jr nz, .notfound |