diff options
author | Rangi <remy.oukaour+rangi42@gmail.com> | 2018-08-25 14:28:22 -0400 |
---|---|---|
committer | Rangi <remy.oukaour+rangi42@gmail.com> | 2018-08-25 14:28:22 -0400 |
commit | eb1e3636bb71509546c274bf2a5910d8e71a9600 (patch) | |
tree | 24d7742604073b2afb86c1225258f8217d1653e7 /engine/events | |
parent | 376c64468bab8d162da43fc6e1b6f0942943cf43 (diff) |
Use labels instead of constants for HRAM
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
Diffstat (limited to 'engine/events')
30 files changed, 206 insertions, 206 deletions
diff --git a/engine/events/battle_tower/battle_tower.asm b/engine/events/battle_tower/battle_tower.asm index 534e2c331..981491547 100644 --- a/engine/events/battle_tower/battle_tower.asm +++ b/engine/events/battle_tower/battle_tower.asm @@ -10,10 +10,10 @@ Function1700ba: ret Function1700c4: - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, $3 - ld [rSVBK], a + ldh [rSVBK], a call Function17042c @@ -47,7 +47,7 @@ Function1700c4: call CopyBytes call CloseSRAM pop af - ld [rSVBK], a + ldh [rSVBK], a ret Function170114: @@ -556,10 +556,10 @@ INCLUDE "data/battle_tower/unknown_levels.asm" CopyBTTrainer_FromBT_OT_TowBT_OTTemp: ; copy the BattleTower-Trainer data that lies at 'wBT_OTTrainer' to 'wBT_OTTemp' - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, BANK(wBT_OTTrainer) - ld [rSVBK], a + ldh [rSVBK], a ld hl, wBT_OTTrainer ld de, wBT_OTTemp @@ -567,7 +567,7 @@ CopyBTTrainer_FromBT_OT_TowBT_OTTemp: call CopyBytes pop af - ld [rSVBK], a + ldh [rSVBK], a ld a, BANK(sBattleTowerChallengeState) call GetSRAMBank @@ -982,7 +982,7 @@ BattleTower_RandomlyChooseReward: ; BattleTowerAction $1e ; Generate a random stat boosting item. .loop call Random - ld a, [hRandomAdd] + ldh a, [hRandomAdd] and $7 cp 6 jr c, .okay @@ -1153,28 +1153,28 @@ Function17081d: ; BattleTowerAction $17 SaveBattleTowerLevelGroup: ; BattleTowerAction $07 ld a, BANK(sBTChoiceOfLevelGroup) call GetSRAMBank - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, $3 - ld [rSVBK], a + ldh [rSVBK], a ld a, [wBTChoiceOfLvlGroup] ld [sBTChoiceOfLevelGroup], a pop af - ld [rSVBK], a + ldh [rSVBK], a call CloseSRAM ret LoadBattleTowerLevelGroup: ; BattleTowerAction $08 ; Load level group choice ld a, BANK(sBTChoiceOfLevelGroup) call GetSRAMBank - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, $3 - ld [rSVBK], a + ldh [rSVBK], a ld a, [sBTChoiceOfLevelGroup] ld [wBTChoiceOfLvlGroup], a pop af - ld [rSVBK], a + ldh [rSVBK], a call CloseSRAM ret @@ -1336,14 +1336,14 @@ String_MysteryJP: db "なぞナゾ@@" ; MYSTERY Function1709aa: ; BattleTowerAction $0f - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, BANK(w3_d090) - ld [rSVBK], a + ldh [rSVBK], a ld a, [w3_d090] ld [wScriptVar], a pop af - ld [rSVBK], a + ldh [rSVBK], a ret Function1709bb: ; BattleTowerAction $10 @@ -1557,17 +1557,17 @@ BattleTowerAction_UbersCheck: ; BattleTowerAction $19 LoadOpponentTrainerAndPokemonWithOTSprite: farcall Function_LoadOpponentTrainerAndPokemons - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, $3 - ld [rSVBK], a + ldh [rSVBK], a ld hl, wBT_OTTrainerClass ld a, [hl] dec a ld c, a ld b, $0 pop af - ld [rSVBK], a + ldh [rSVBK], a ld hl, BTTrainerClassSprites add hl, bc ld a, [hl] @@ -1593,9 +1593,9 @@ LoadOpponentTrainerAndPokemonWithOTSprite: ld hl, wUsedSprites add hl, de ld [hli], a - ld [hUsedSpriteIndex], a + ldh [hUsedSpriteIndex], a ld a, [hl] - ld [hUsedSpriteTile], a + ldh [hUsedSpriteTile], a farcall GetUsedSprite ret diff --git a/engine/events/battle_tower/load_trainer.asm b/engine/events/battle_tower/load_trainer.asm index f9be02b28..517b0e48e 100644 --- a/engine/events/battle_tower/load_trainer.asm +++ b/engine/events/battle_tower/load_trainer.asm @@ -1,8 +1,8 @@ Function_LoadOpponentTrainerAndPokemons: - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, BANK(wBT_OTTrainer) - ld [rSVBK], a + ldh [rSVBK], a ; Fill wBT_OTTrainer with zeros xor a @@ -19,11 +19,11 @@ Function_LoadOpponentTrainerAndPokemons: ; Set wBT_OTTrainer as start address to write the following data to ld de, wBT_OTTrainer - ld a, [hRandomAdd] + ldh a, [hRandomAdd] ld b, a .resample ; loop to find a random trainer call Random - ld a, [hRandomAdd] + ldh a, [hRandomAdd] add b ld b, a ; b contains the nr of the trainer if DEF(_CRYSTAL11) @@ -87,7 +87,7 @@ endc jr nz, .copy_bt_trainer_data_loop pop af - ld [rSVBK], a + ldh [rSVBK], a ret @@ -107,11 +107,11 @@ Function_LoadRandomBattleTowerMon: ld bc, BattleTowerMons2 - BattleTowerMons1 ; size of one level group call AddNTimes - ld a, [hRandomAdd] + ldh a, [hRandomAdd] ld b, a .resample call Random - ld a, [hRandomAdd] + ldh a, [hRandomAdd] add b ld b, a maskbits BATTLETOWER_NUM_UNIQUE_MON diff --git a/engine/events/battle_tower/trainer_text.asm b/engine/events/battle_tower/trainer_text.asm index e2db148b7..0743741e6 100644 --- a/engine/events/battle_tower/trainer_text.asm +++ b/engine/events/battle_tower/trainer_text.asm @@ -3,10 +3,10 @@ BattleTowerText:: ; 1: Intro text ; 2: Player lost ; 3: Player won - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, BANK(wBT_OTTrainerClass) - ld [rSVBK], a + ldh [rSVBK], a if DEF(_CRYSTAL11) ld hl, wBT_OTTrainerClass else @@ -28,7 +28,7 @@ endc and a jr nz, .female ; generate a random number between 0 and 24 - ld a, [hRandomAdd] + ldh a, [hRandomAdd] and $1f cp 25 jr c, .okay0 @@ -40,7 +40,7 @@ endc .female ; generate a random number between 0 and 14 - ld a, [hRandomAdd] + ldh a, [hRandomAdd] and $f cp 15 jr c, .okay1 @@ -80,7 +80,7 @@ endc ld h, a bccoord 1, 14 pop af - ld [rSVBK], a + ldh [rSVBK], a call PlaceHLTextAtBC ret diff --git a/engine/events/buena.asm b/engine/events/buena.asm index c5260760a..3b8fa26f1 100644 --- a/engine/events/buena.asm +++ b/engine/events/buena.asm @@ -188,7 +188,7 @@ PrintBlueCardBalance: .DrawBox: push de xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a ld hl, BlueCardBalanceMenuHeader call CopyMenuHeader call MenuBox @@ -232,7 +232,7 @@ Buena_PrizeMenu: ld [wMenuCursorBuffer], a xor a ld [wWhichIndexSet], a - ld [hBGMapMode], a + ldh [hBGMapMode], a call InitScrollingMenu call UpdateSprites call ScrollingMenu diff --git a/engine/events/buena_menu.asm b/engine/events/buena_menu.asm index e498a3ab8..fada80138 100644 --- a/engine/events/buena_menu.asm +++ b/engine/events/buena_menu.asm @@ -43,16 +43,16 @@ AskRememberPassword: ret Buena_ExitMenu: - ld a, [hOAMUpdate] + ldh a, [hOAMUpdate] push af call ExitMenu call UpdateSprites xor a - ld [hOAMUpdate], a + ldh [hOAMUpdate], a call DelayFrame ld a, $1 - ld [hOAMUpdate], a + ldh [hOAMUpdate], a call ApplyTilemap pop af - ld [hOAMUpdate], a + ldh [hOAMUpdate], a ret diff --git a/engine/events/bug_contest/judging.asm b/engine/events/bug_contest/judging.asm index a6ec3baf6..a23535998 100644 --- a/engine/events/bug_contest/judging.asm +++ b/engine/events/bug_contest/judging.asm @@ -150,9 +150,9 @@ BugContest_JudgeContestants: ld [hli], a ld a, [wContestMon] ld [hli], a - ld a, [hProduct] + ldh a, [hProduct] ld [hli], a - ld a, [hProduct + 1] + ldh a, [hProduct + 1] ld [hl], a call DetermineContestWinners ret @@ -287,8 +287,8 @@ ContestScore: ; Determine the player's score in the Bug Catching Contest. xor a - ld [hProduct], a - ld [hMultiplicand], a + ldh [hProduct], a + ldh [hMultiplicand], a ld a, [wContestMonSpecies] ; Species and a diff --git a/engine/events/catch_tutorial.asm b/engine/events/catch_tutorial.asm index 898fb826f..395b32d3d 100644 --- a/engine/events/catch_tutorial.asm +++ b/engine/events/catch_tutorial.asm @@ -31,8 +31,8 @@ CatchTutorial:: call .LoadDudeData xor a - ld [hJoyDown], a - ld [hJoyPressed], a + ldh [hJoyDown], a + ldh [hJoyPressed], a ld a, [wOptions] push af and $f8 diff --git a/engine/events/daycare.asm b/engine/events/daycare.asm index 4e98c5382..04e1c9090 100644 --- a/engine/events/daycare.asm +++ b/engine/events/daycare.asm @@ -656,11 +656,11 @@ DayCare_InitBreeding: ld d, a callfar CalcExpAtLevel ld hl, wEggMonExp - ld a, [hMultiplicand] + ldh a, [hMultiplicand] ld [hli], a - ld a, [hMultiplicand + 1] + ldh a, [hMultiplicand + 1] ld [hli], a - ld a, [hMultiplicand + 2] + ldh a, [hMultiplicand + 2] ld [hl], a xor a ld b, wEggMonDVs - wEggMonStatExp diff --git a/engine/events/field_moves.asm b/engine/events/field_moves.asm index a6edbc08c..42e8298a7 100644 --- a/engine/events/field_moves.asm +++ b/engine/events/field_moves.asm @@ -62,7 +62,7 @@ ShakeHeadbuttTree: call OverworldTextModeSwitch call WaitBGMap xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a farcall ClearSpriteAnims ld hl, wVirtualOAMSprite36 ld bc, wVirtualOAMEnd - wVirtualOAMSprite36 @@ -80,7 +80,7 @@ INCBIN "gfx/overworld/headbutt_tree.2bpp" HideHeadbuttTree: xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a ld a, [wPlayerDirection] and %00001100 srl a @@ -101,7 +101,7 @@ HideHeadbuttTree: ld [hld], a call WaitBGMap xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a ret TreeRelativeLocationTable: @@ -205,7 +205,7 @@ Cut_SpawnAnimateLeaves: Cut_StartWaiting: ld a, $1 - ld [hBGMapMode], a + ldh [hBGMapMode], a ; Cut_WaitAnimSFX ld hl, wJumptableIndex inc [hl] diff --git a/engine/events/fishing_gfx.asm b/engine/events/fishing_gfx.asm index 159f0022d..e8878b6f2 100644 --- a/engine/events/fishing_gfx.asm +++ b/engine/events/fishing_gfx.asm @@ -1,8 +1,8 @@ LoadFishingGFX: - ld a, [rVBK] + ldh a, [rVBK] push af ld a, $1 - ld [rVBK], a + ldh [rVBK], a ld de, FishingGFX ld a, [wPlayerGender] @@ -21,7 +21,7 @@ LoadFishingGFX: call .LoadGFX pop af - ld [rVBK], a + ldh [rVBK], a ret .LoadGFX: diff --git a/engine/events/halloffame.asm b/engine/events/halloffame.asm index 752ec965b..00b910166 100644 --- a/engine/events/halloffame.asm +++ b/engine/events/halloffame.asm @@ -44,7 +44,7 @@ RedCredits:: farcall FadeOutPalettes xor a ld [wVramState], a - ld [hMapAnims], a + ldh [hMapAnims], a farcall InitDisplayForRedCredits ld c, 8 call DelayFrames @@ -66,7 +66,7 @@ HallOfFame_FadeOutMusic: farcall FadeOutPalettes xor a ld [wVramState], a - ld [hMapAnims], a + ldh [hMapAnims], a farcall InitDisplayForHallOfFame ld c, 100 jp DelayFrames @@ -243,17 +243,17 @@ AnimateHOFMonEntrance: ld de, vTiles2 tile $31 predef GetMonBackpic ld a, $31 - ld [hGraphicStartTile], a + ldh [hGraphicStartTile], a hlcoord 6, 6 lb bc, 6, 6 predef PlaceGraphic ld a, $d0 - ld [hSCY], a + ldh [hSCY], a ld a, $90 - ld [hSCX], a + ldh [hSCX], a call WaitBGMap xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a ld b, SCGB_PLAYER_OR_MON_FRONTPIC_PALS call GetSGBLayout call SetPalettes @@ -268,29 +268,29 @@ AnimateHOFMonEntrance: call _PrepMonFrontpic call WaitBGMap xor a - ld [hBGMapMode], a - ld [hSCY], a + ldh [hBGMapMode], a + ldh [hSCY], a call HOF_SlideFrontpic ret HOF_SlideBackpic: .backpicloop - ld a, [hSCX] + ldh a, [hSCX] cp $70 ret z add $4 - ld [hSCX], a + ldh [hSCX], a call DelayFrame jr .backpicloop HOF_SlideFrontpic: .frontpicloop - ld a, [hSCX] + ldh a, [hSCX] and a ret z dec a dec a - ld [hSCX], a + ldh [hSCX], a call DelayFrame jr .frontpicloop @@ -432,7 +432,7 @@ LoadHOFTeam: DisplayHOFMon: xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a ld a, [hli] ld [wTempMonSpecies], a ld a, [hli] @@ -528,17 +528,17 @@ HOF_AnimatePlayerPic: call ByteFill farcall GetPlayerBackpic ld a, $31 - ld [hGraphicStartTile], a + ldh [hGraphicStartTile], a hlcoord 6, 6 lb bc, 6, 6 predef PlaceGraphic ld a, $d0 - ld [hSCY], a + ldh [hSCY], a ld a, $90 - ld [hSCX], a + ldh [hSCX], a call WaitBGMap xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a ld [wCurPartySpecies], a ld b, SCGB_PLAYER_OR_MON_FRONTPIC_PALS call GetSGBLayout @@ -552,19 +552,19 @@ HOF_AnimatePlayerPic: call ByteFill farcall HOF_LoadTrainerFrontpic xor a - ld [hGraphicStartTile], a + ldh [hGraphicStartTile], a hlcoord 12, 5 lb bc, 7, 7 predef PlaceGraphic ld a, $c0 - ld [hSCX], a + ldh [hSCX], a call WaitBGMap xor a - ld [hBGMapMode], a - ld [hSCY], a + ldh [hBGMapMode], a + ldh [hSCY], a call HOF_SlideFrontpic xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a hlcoord 0, 2 lb bc, 8, 9 call TextBox diff --git a/engine/events/heal_machine_anim.asm b/engine/events/heal_machine_anim.asm index 559886289..28b2c8a4c 100644 --- a/engine/events/heal_machine_anim.asm +++ b/engine/events/heal_machine_anim.asm @@ -18,7 +18,7 @@ HealMachineAnim: ; 2: Up (Hall of Fame) ld a, [wScriptVar] ld [wBuffer1], a - ld a, [rOBP1] + ldh a, [rOBP1] ld [wBuffer2], a call .DoJumptableFunctions ld a, [wBuffer2] @@ -158,7 +158,7 @@ INCBIN "gfx/overworld/heal_machine.2bpp" call IsCGB jr nz, .cgb ld a, %11100000 - ld [rOBP1], a + ldh [rOBP1], a ret .cgb @@ -168,7 +168,7 @@ INCBIN "gfx/overworld/heal_machine.2bpp" ld a, BANK(wOBPals2) call FarCopyWRAM ld a, $1 - ld [hCGBPalUpdate], a + ldh [hCGBPalUpdate], a ret .palettes @@ -189,16 +189,16 @@ INCLUDE "gfx/overworld/heal_machine.pal" .FlashPalettes: call IsCGB jr nz, .go - ld a, [rOBP1] + ldh a, [rOBP1] xor %00101000 - ld [rOBP1], a + ldh [rOBP1], a ret .go - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, BANK(wOBPals2) - ld [rSVBK], a + ldh [rSVBK], a ld hl, wOBPals2 palette PAL_OW_TREE ld a, [hli] @@ -230,9 +230,9 @@ INCLUDE "gfx/overworld/heal_machine.pal" ld [hl], a pop af - ld [rSVBK], a + ldh [rSVBK], a ld a, $1 - ld [hCGBPalUpdate], a + ldh [hCGBPalUpdate], a ret .PlaceHealingMachineTile: diff --git a/engine/events/kurt.asm b/engine/events/kurt.asm index d4342b3e4..9d4ed3e11 100644 --- a/engine/events/kurt.asm +++ b/engine/events/kurt.asm @@ -59,7 +59,7 @@ Kurt_SelectApricorn: ld a, [wMenuSelection] ld [wMenuCursorBuffer], a xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a call InitScrollingMenu call UpdateSprites call ScrollingMenu @@ -124,7 +124,7 @@ Kurt_SelectQuantity: call LoadMenuHeader .loop xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a call MenuBox call UpdateSprites call .PlaceApricornName diff --git a/engine/events/magikarp.asm b/engine/events/magikarp.asm index db415c65e..8f0c8d39a 100644 --- a/engine/events/magikarp.asm +++ b/engine/events/magikarp.asm @@ -198,30 +198,30 @@ CalcMagikarpLength: ; c = (bc - de) / [hl] call .BCMinusDE ld a, b - ld [hDividend + 0], a + ldh [hDividend + 0], a ld a, c - ld [hDividend + 1], a + ldh [hDividend + 1], a ld a, [hl] - ld [hDivisor], a + ldh [hDivisor], a ld b, 2 call Divide - ld a, [hQuotient + 2] + ldh a, [hQuotient + 2] ld c, a ; de = c + 100 × (2 + i) xor a - ld [hMultiplicand + 0], a - ld [hMultiplicand + 1], a + ldh [hMultiplicand + 0], a + ldh [hMultiplicand + 1], a ld a, 100 - ld [hMultiplicand + 2], a + ldh [hMultiplicand + 2], a ld a, [wTempByteValue] - ld [hMultiplier], a + ldh [hMultiplier], a call Multiply ld b, 0 - ld a, [hProduct + 3] + ldh a, [hProduct + 3] add c ld e, a - ld a, [hProduct + 2] + ldh a, [hProduct + 2] adc b ld d, a jr .done diff --git a/engine/events/magnet_train.asm b/engine/events/magnet_train.asm index 010983627..1146b73b6 100644 --- a/engine/events/magnet_train.asm +++ b/engine/events/magnet_train.asm @@ -14,10 +14,10 @@ MagnetTrain: .continue ld h, a - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, BANK(wMagnetTrain) - ld [rSVBK], a + ldh [rSVBK], a ld a, h ld [wMagnetTrainDirection], a @@ -30,9 +30,9 @@ MagnetTrain: ld a, d ld [wMagnetTrainPlayerSpriteInitX], a - ld a, [hSCX] + ldh a, [hSCX] push af - ld a, [hSCY] + ldh a, [hSCY] push af call MagntTrain_LoadGFX_PlayMusic ld hl, hVBlank @@ -58,13 +58,13 @@ MagnetTrain: .done pop af - ld [hVBlank], a + ldh [hVBlank], a call ClearBGPalettes xor a - ld [hLCDCPointer], a - ld [hLYOverrideStart], a - ld [hLYOverrideEnd], a - ld [hSCX], a + ldh [hLCDCPointer], a + ldh [hLYOverrideStart], a + ldh [hLYOverrideEnd], a + ldh [hSCX], a ld [wRequested2bppSource], a ld [wRequested2bppSource + 1], a ld [wRequested2bppDest], a @@ -73,13 +73,13 @@ MagnetTrain: call ClearTileMap pop af - ld [hSCY], a + ldh [hSCY], a pop af - ld [hSCX], a + ldh [hSCX], a xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a pop af - ld [rSVBK], a + ldh [rSVBK], a ret MagnetTrain_UpdateLYOverrides: @@ -87,7 +87,7 @@ MagnetTrain_UpdateLYOverrides: ld c, $2f ld a, [wMagnetTrainOffset] add a - ld [hSCX], a + ldh [hSCX], a call .loadloop ld c, $30 ld a, [wMagnetTrainPosition] @@ -119,19 +119,19 @@ MagntTrain_LoadGFX_PlayMusic: call SetMagnetTrainPals call DrawMagnetTrain ld a, $90 - ld [hWY], a + ldh [hWY], a call EnableLCD xor a - ld [hBGMapMode], a - ld [hSCX], a - ld [hSCY], a - ld a, [rSVBK] + ldh [hBGMapMode], a + ldh [hSCX], a + ldh [hSCY], a + ldh a, [rSVBK] push af ld a, BANK(wPlayerGender) - ld [rSVBK], a + ldh [rSVBK], a farcall GetPlayerIcon pop af - ld [rSVBK], a + ldh [rSVBK], a ld hl, vTiles0 ld c, 4 call Request2bpp @@ -243,12 +243,12 @@ MagnetTrain_InitLYOverrides: ld a, [wMagnetTrainInitPosition] call ByteFill ld a, rSCX - $ff00 - ld [hLCDCPointer], a + ldh [hLCDCPointer], a ret SetMagnetTrainPals: ld a, $1 - ld [rVBK], a + ldh [rVBK], a ; bushes hlbgcoord 0, 0 @@ -275,7 +275,7 @@ SetMagnetTrainPals: call ByteFill ld a, $0 - ld [rVBK], a + ldh [rVBK], a ret MagnetTrain_Jumptable: @@ -309,10 +309,10 @@ MagnetTrain_Jumptable: ld a, [wMagnetTrainPlayerSpriteInitX] ld e, a ld b, SPRITE_ANIM_INDEX_MAGNET_TRAIN_RED - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, BANK(wPlayerGender) - ld [rSVBK], a + ldh [rSVBK], a ld a, [wPlayerGender] bit PLAYERGENDER_FEMALE_F, a jr z, .got_gender @@ -320,7 +320,7 @@ MagnetTrain_Jumptable: .got_gender pop af - ld [rSVBK], a + ldh [rSVBK], a ld a, b call _InitSpriteAnimStruct ld hl, SPRITEANIMSTRUCT_TILE_ID @@ -408,10 +408,10 @@ MagnetTrain_Jumptable_FirstRunThrough: call MagnetTrain_UpdateLYOverrides call PushLYOverrides call DelayFrame - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, BANK(wEnvironment) - ld [rSVBK], a + ldh [rSVBK], a ld a, [wTimeOfDayPal] push af ld a, [wEnvironment] @@ -424,18 +424,18 @@ MagnetTrain_Jumptable_FirstRunThrough: ld b, SCGB_MAPPALS call GetSGBLayout call UpdateTimePals - ld a, [rBGP] + ldh a, [rBGP] ld [wBGP], a - ld a, [rOBP0] + ldh a, [rOBP0] ld [wOBP0], a - ld a, [rOBP1] + ldh a, [rOBP1] ld [wOBP1], a pop af ld [wEnvironment], a pop af ld [wTimeOfDayPal], a pop af - ld [rSVBK], a + ldh [rSVBK], a ret MagnetTrainTilemap1: diff --git a/engine/events/map_name_sign.asm b/engine/events/map_name_sign.asm index 859f30034..a1700420b 100644 --- a/engine/events/map_name_sign.asm +++ b/engine/events/map_name_sign.asm @@ -2,7 +2,7 @@ MAP_NAME_SIGN_START EQU $60 ReturnFromMapSetupScript:: xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a farcall .inefficient_farcall ; this is a waste of 6 ROM bytes and 6 stack bytes ret @@ -51,10 +51,10 @@ ReturnFromMapSetupScript:: ld a, [wCurrentLandmark] ld [wPreviousLandmark], a ld a, $90 - ld [rWY], a - ld [hWY], a + ldh [rWY], a + ldh [hWY], a xor a - ld [hLCDCPointer], a + ldh [hLCDCPointer], a ret .CheckMovingWithinLandmark: @@ -112,16 +112,16 @@ PlaceMapNameSign:: .skip2 ld a, $80 ld a, $70 - ld [rWY], a - ld [hWY], a + ldh [rWY], a + ldh [hWY], a ret .disappear ld a, $90 - ld [rWY], a - ld [hWY], a + ldh [rWY], a + ldh [hWY], a xor a - ld [hLCDCPointer], a + ldh [hLCDCPointer], a ret LoadMapNameSignGFX: diff --git a/engine/events/mom.asm b/engine/events/mom.asm index adaee701f..fee89f69c 100644 --- a/engine/events/mom.asm +++ b/engine/events/mom.asm @@ -1,8 +1,8 @@ BankOfMom: - ld a, [hInMenu] + ldh a, [hInMenu] push af ld a, $1 - ld [hInMenu], a + ldh [hInMenu], a xor a ld [wJumptableIndex], a .loop @@ -14,7 +14,7 @@ BankOfMom: .done pop af - ld [hInMenu], a + ldh [hInMenu], a ret .RunJumptable: @@ -295,7 +295,7 @@ DSTChecks: ; check the time; avoid changing DST if doing so would change the current day ld a, [wDST] bit 7, a - ld a, [hHours] + ldh a, [hHours] jr z, .NotDST and a ; within one hour of 00:00? jr z, .LostBooklet @@ -429,7 +429,7 @@ Mom_SetUpDepositMenu: Mom_ContinueMenuSetup: push de xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a hlcoord 0, 0 lb bc, 6, 18 call TextBox @@ -475,7 +475,7 @@ Mom_WithdrawDepositMenuJoypad: jr nz, .pressedA call .dpadaction xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a hlcoord 12, 6 ld bc, 7 ld a, " " @@ -484,7 +484,7 @@ Mom_WithdrawDepositMenuJoypad: ld de, wStringBuffer2 lb bc, PRINTNUM_MONEY | PRINTNUM_LEADINGZEROS | 3, 6 call PrintNum - ld a, [hVBlankCounter] + ldh a, [hVBlankCounter] and $10 jr nz, .skip hlcoord 13, 6 diff --git a/engine/events/mom_phone.asm b/engine/events/mom_phone.asm index dc10ede35..154d4440c 100644 --- a/engine/events/mom_phone.asm +++ b/engine/events/mom_phone.asm @@ -61,11 +61,11 @@ CheckBalance_MomItem2: jr nc, .nope call GetItemFromMom ld a, [hli] - ld [hMoneyTemp], a + ldh [hMoneyTemp], a ld a, [hli] - ld [hMoneyTemp + 1], a + ldh [hMoneyTemp + 1], a ld a, [hli] - ld [hMoneyTemp + 2], a + ldh [hMoneyTemp + 2], a ld de, wMomsMoney ld bc, hMoneyTemp farcall CompareMoney @@ -118,11 +118,11 @@ MomBuysItem_DeductFunds: ld de, 3 ; cost add hl, de ld a, [hli] - ld [hMoneyTemp], a + ldh [hMoneyTemp], a ld a, [hli] - ld [hMoneyTemp + 1], a + ldh [hMoneyTemp + 1], a ld a, [hli] - ld [hMoneyTemp + 2], a + ldh [hMoneyTemp + 2], a ld de, wMomsMoney ld bc, hMoneyTemp farcall TakeMoney diff --git a/engine/events/odd_egg.asm b/engine/events/odd_egg.asm index a6b244b1d..74b971806 100644 --- a/engine/events/odd_egg.asm +++ b/engine/events/odd_egg.asm @@ -23,13 +23,13 @@ _GiveOddEgg: .not_done ; Break when [hRandom] <= de. - ld a, [hRandom + 1] + ldh a, [hRandom + 1] cp d jr c, .done jr z, .ok jr .next .ok - ld a, [hRandom + 0] + ldh a, [hRandom + 0] cp e jr c, .done jr z, .done diff --git a/engine/events/overworld.asm b/engine/events/overworld.asm index e57635fef..5c20e980f 100644 --- a/engine/events/overworld.asm +++ b/engine/events/overworld.asm @@ -226,7 +226,7 @@ CutDownTreeOrGrass: ld a, [wBuffer5] ; ReplacementTile ld [hl], a xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a call OverworldTextModeSwitch call UpdateSprites call DelayFrame @@ -575,7 +575,7 @@ FlyFunction: .outdoors xor a - ld [hMapAnims], a + ldh [hMapAnims], a call LoadStandardMenuHeader call ClearSprites farcall _FlyMap @@ -1199,7 +1199,7 @@ DisappearWhirlpool: ld a, [wBuffer5] ld [hl], a xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a call OverworldTextModeSwitch ld a, [wBuffer6] ld e, a @@ -1360,12 +1360,12 @@ GetFacingObject: farcall CheckFacingObject jr nc, .fail - ld a, [hObjectStructIndexBuffer] + ldh a, [hObjectStructIndexBuffer] call GetObjectStruct ld hl, OBJECT_MAP_OBJECT_INDEX add hl, bc ld a, [hl] - ld [hLastTalked], a + ldh [hLastTalked], a call GetMapObject ld hl, MAPOBJECT_MOVEMENT add hl, bc @@ -1623,7 +1623,7 @@ MovementData_0xd093: PutTheRodAway: xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a ld a, $1 ld [wPlayerAction], a call UpdateSprites diff --git a/engine/events/poisonstep_pals.asm b/engine/events/poisonstep_pals.asm index 354aabb28..b2de25fa6 100644 --- a/engine/events/poisonstep_pals.asm +++ b/engine/events/poisonstep_pals.asm @@ -1,12 +1,12 @@ LoadPoisonBGPals: call .LoadPals - ld a, [hCGB] + ldh a, [hCGB] and a ret nz ret ; ???? .LoadPals: - ld a, [hCGB] + ldh a, [hCGB] and a jr nz, .cgb ld a, [wTimeOfDayPal] @@ -24,10 +24,10 @@ LoadPoisonBGPals: ret .cgb - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, BANK(wBGPals2) - ld [rSVBK], a + ldh [rSVBK], a ld hl, wBGPals2 ld c, 4 palettes .loop @@ -38,9 +38,9 @@ LoadPoisonBGPals: dec c jr nz, .loop pop af - ld [rSVBK], a + ldh [rSVBK], a ld a, $1 - ld [hCGBPalUpdate], a + ldh [hCGBPalUpdate], a ld c, 4 call DelayFrames farcall _UpdateTimePals diff --git a/engine/events/pokecenter_pc.asm b/engine/events/pokecenter_pc.asm index 8f73fc41e..43bf6dbfe 100644 --- a/engine/events/pokecenter_pc.asm +++ b/engine/events/pokecenter_pc.asm @@ -10,7 +10,7 @@ PokemonCenterPC: call LoadMenuHeader .loop xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a call .ChooseWhichPCListToUse ld [wWhichIndexSet], a call DoNthMenu @@ -360,7 +360,7 @@ PlayerWithdrawItemMenu: ld hl, .WithdrewText call MenuTextBox xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a call ExitMenu ret diff --git a/engine/events/pokepic.asm b/engine/events/pokepic.asm index 10ca4280b..523c5df5e 100644 --- a/engine/events/pokepic.asm +++ b/engine/events/pokepic.asm @@ -7,7 +7,7 @@ Pokepic:: ld b, SCGB_POKEPIC call GetSGBLayout xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a ld a, [wCurPartySpecies] ld [wCurSpecies], a call GetBaseData @@ -21,7 +21,7 @@ Pokepic:: ld c, a call Coord2Tile ld a, $80 - ld [hGraphicStartTile], a + ldh [hGraphicStartTile], a lb bc, 7, 7 predef PlaceGraphic call WaitBGMap @@ -34,7 +34,7 @@ ClosePokepic:: call WaitBGMap call GetMemSGBLayout xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a call OverworldTextModeSwitch call ApplyTilemap call UpdateSprites diff --git a/engine/events/pokerus/pokerus.asm b/engine/events/pokerus/pokerus.asm index a6764e3b5..63eb7fe10 100644 --- a/engine/events/pokerus/pokerus.asm +++ b/engine/events/pokerus/pokerus.asm @@ -22,10 +22,10 @@ GivePokerusAndConvertBerries: bit STATUSFLAGS2_REACHED_GOLDENROD_F, [hl] ret z call Random - ld a, [hRandomAdd] + ldh a, [hRandomAdd] and a ret nz - ld a, [hRandomSub] + ldh a, [hRandomSub] cp $3 ret nc ; 3/65536 chance (00 00, 00 01 or 00 02) ld a, [wPartyCount] diff --git a/engine/events/print_photo.asm b/engine/events/print_photo.asm index cb29693af..9854239f5 100644 --- a/engine/events/print_photo.asm +++ b/engine/events/print_photo.asm @@ -12,7 +12,7 @@ PhotoStudio: call DisableSpriteUpdates farcall PrintPartymon call ReturnToMapWithSpeechTextbox - ld a, [hPrinter] + ldh a, [hPrinter] and a jr nz, .cancel ld hl, .Text_Presto diff --git a/engine/events/print_unown.asm b/engine/events/print_unown.asm index 9e231f449..fb0abd52b 100644 --- a/engine/events/print_unown.asm +++ b/engine/events/print_unown.asm @@ -6,10 +6,10 @@ _UnownPrinter: and a ret z - ld a, [hInMenu] + ldh a, [hInMenu] push af ld a, $1 - ld [hInMenu], a + ldh [hInMenu], a ld a, [wOptions] push af set NO_TEXT_SCROLL, a @@ -69,11 +69,11 @@ _UnownPrinter: .joy_loop call JoyTextDelay - ld a, [hJoyPressed] + ldh a, [hJoyPressed] and B_BUTTON jr nz, .pressed_b - ld a, [hJoyPressed] + ldh a, [hJoyPressed] and A_BUTTON jr nz, .pressed_a @@ -94,15 +94,15 @@ _UnownPrinter: pop af ld [wOptions], a pop af - ld [hInMenu], a + ldh [hInMenu], a call ReturnToMapFromSubmenu ret .LeftRight: - ld a, [hJoyLast] + ldh a, [hJoyLast] and D_RIGHT jr nz, .press_right - ld a, [hJoyLast] + ldh a, [hJoyLast] and D_LEFT jr nz, .press_left ret @@ -145,7 +145,7 @@ _UnownPrinter: call .Load2bppToSRAM hlcoord 1, 6 xor a - ld [hGraphicStartTile], a + ldh [hGraphicStartTile], a lb bc, 7, 7 predef PlaceGraphic ld de, vTiles2 tile $31 @@ -153,23 +153,23 @@ _UnownPrinter: ret .Load2bppToSRAM: - ld a, [rSVBK] + ldh a, [rSVBK] push af ld a, BANK(wDecompressScratch) - ld [rSVBK], a + ldh [rSVBK], a ld a, BANK(sScratch) call GetSRAMBank ld de, wDecompressScratch ld hl, sScratch - ld a, [hROMBank] + ldh a, [hROMBank] ld b, a ld c, $31 call Get2bpp call CloseSRAM pop af - ld [rSVBK], a + ldh [rSVBK], a ret .vacant @@ -188,7 +188,7 @@ _UnownPrinter: ld hl, vTiles2 tile $31 ld de, sScratch ld c, $31 - ld a, [hROMBank] + ldh a, [hROMBank] ld b, a call Get2bpp call CloseSRAM @@ -224,7 +224,7 @@ PlaceUnownPrinterFrontpic: call ByteFill hlcoord 7, 11 ld a, $31 - ld [hGraphicStartTile], a + ldh [hGraphicStartTile], a lb bc, 7, 7 predef PlaceGraphic ret diff --git a/engine/events/print_unown_2.asm b/engine/events/print_unown_2.asm index 02f3fadd9..77eb050a1 100644 --- a/engine/events/print_unown_2.asm +++ b/engine/events/print_unown_2.asm @@ -37,7 +37,7 @@ RotateUnownFrontpic: pop hl ld de, sScratch ld c, 7 * 7 - ld a, [hROMBank] + ldh a, [hROMBank] ld b, a call Get2bpp call CloseSRAM diff --git a/engine/events/specials.asm b/engine/events/specials.asm index be554f1bc..07577232a 100644 --- a/engine/events/specials.asm +++ b/engine/events/specials.asm @@ -380,11 +380,11 @@ PlayCurMonCry: jp PlayMonCry GameboyCheck: - ld a, [hCGB] + ldh a, [hCGB] and a jr nz, .cgb - ld a, [hSGB] + ldh a, [hSGB] and a jr nz, .sgb diff --git a/engine/events/treemons.asm b/engine/events/treemons.asm index cd78421d6..c02884ce3 100644 --- a/engine/events/treemons.asm +++ b/engine/events/treemons.asm @@ -242,34 +242,34 @@ GetTreeScore: add hl, bc ld a, h - ld [hDividend], a + ldh [hDividend], a ld a, l - ld [hDividend + 1], a + ldh [hDividend + 1], a ld a, 5 - ld [hDivisor], a + ldh [hDivisor], a ld b, 2 call Divide - ld a, [hQuotient + 1] - ld [hDividend], a - ld a, [hQuotient + 2] - ld [hDividend + 1], a + ldh a, [hQuotient + 1] + ldh [hDividend], a + ldh a, [hQuotient + 2] + ldh [hDividend + 1], a ld a, 10 - ld [hDivisor], a + ldh [hDivisor], a ld b, 2 call Divide - ld a, [hQuotient + 3] + ldh a, [hQuotient + 3] ret .OTIDScore: ld a, [wPlayerID] - ld [hDividend], a + ldh [hDividend], a ld a, [wPlayerID + 1] - ld [hDividend + 1], a + ldh [hDividend + 1], a ld a, 10 - ld [hDivisor], a + ldh [hDivisor], a ld b, 2 call Divide - ld a, [hQuotient + 3] + ldh a, [hQuotient + 3] ret diff --git a/engine/events/unown_walls.asm b/engine/events/unown_walls.asm index 105337630..28020c960 100644 --- a/engine/events/unown_walls.asm +++ b/engine/events/unown_walls.asm @@ -115,7 +115,7 @@ DisplayUnownWords: .load call LoadMenuHeader xor a - ld [hBGMapMode], a + ldh [hBGMapMode], a call MenuBox call UpdateSprites call ApplyTilemap |