summaryrefslogtreecommitdiff
path: root/engine
AgeCommit message (Collapse)Author
2018-08-25Use rgbasm's GameBoy graphics literal for initializing wCreditsFaux2bppRangi
In the 2BPP format, two bytes %ABCDEFGH %abcdefgh define eight pixels %Aa %Bb %Cc %Dd %Ee %Ff %Gg %Hh. Four valid colors: %00 = 0 = white, %01 = 1 = dark, %10 = 2 = light, %11 = 3 = black. Thus `22222222 = pixels %10 %10 %10 %10 %10 %10 %10 %10 = bytes %11111111 %00000000 = $ff00.
2018-08-25Reorganize math-related HRAM union (ffb3)Rangi
2018-08-25These are signed offsets, not addresses (thanks, PikalaxALT)Rangi
2018-08-25Remove HRAM label address commentsRangi
2018-08-25hLabel - $ff00 -> LOW(hLabel)Rangi
2018-08-25Use labels instead of constants for HRAMRangi
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-17CheckDestinyBond -> CheckFaintmid-kid
Its main function is fainting the opponent and ending the move effect. Updated the comment accordingly.
2018-08-17Fix some StatUp-related labelsmid-kid
2018-08-16GetDamageStatsCritical -> CheckDamageStatsCriticalmid-kid
Clarified its usage, as the comments surrounding it were factually wrong.
2018-08-07Fix more uses of EFFECTIVEmid-kid
2018-08-07Fix constants in BattleCommand_MirrorCoatmid-kid
2018-08-07wWeeklyFlags -> wDailyFlags2mid-kid
These are by far not always checked each week, and as such shouldn't be called that. Since they're almost always used through the `bit` instruction, it's very inconvenient to just make wDailyFlags a `dw` instead.
2018-08-07RestorePPofDepositedPokemon -> RestorePPOfDepositedPokemonmid-kid
2018-08-07Split print_move_description and mon_menumid-kid
2018-07-29Pokedex_PutScrollbarOAM data valuesRangi
2018-07-29No wCurMove alias for wCurSpeciesRangi
2018-07-29Fix reviewed issues.Rangi
Pokedex_PrintListing has a comment noting how it depends on wCurSpecies == wNamedObjectIndexBuffer; an assert would be more convenient, but is not possible since WRAM label addresses are not defined yet here.
2018-07-29Make reviewed fixes; standardize on " + "Rangi
2018-07-29wSwitchMonRangi
2018-07-29wLuckyNumberDigitsBufferRangi
2018-07-29Improve wTrainerHUDTiles usageRangi
2018-07-29; entries correspond to PLAYEREVENT_* constantsRangi
2018-07-29Add meaningful aliases for wd265Rangi
Introduce MONICON_* constants Introduce BATTLEPLAYERACTION_* constants
2018-07-27Crystal fixed TruncateHL_BC in single playerRangi
2018-07-27Merge branch 'master' of https://github.com/pret/pokecrystalmid-kid
2018-07-26Remove a documented bug that's not really a bugmid-kid
I mean, technically, being able to read beyond a data table's size is bad practice, but there's so many cases of this that it's not worth mentioning. For most of these cases, at least, it's safe to assume the index won't ever get high enough to surpass such a table's length, because it's either hardcoded or decided by the game without the use of uncontrollable data. As such, they don't expose any actual bugs.
2018-07-26Consistently use the diff format in bugs_and_glitchesmid-kid
2018-07-24MON_STAT_EXP - 1 → MON_EXP + 2Rangi
2018-07-23wPokeAnimStruct matches wPokeAnimStructEndRangi
2018-07-23StringCmp → CompareBytes; CompareLong → CompareBytesLongRangi
hStringCmpString[1/2] → h[EnemyMon/PartyMon1]Speed
2018-07-23Consistent routine naming convention: 'Foo' wraps '_Foo'Rangi
2018-07-22ANIM_MON_UNUSED → ANIM_MON_HOFRangi
2018-07-21Merge branch 'master' of hyperdriveguy/pokecrystalIIMarckus
2018-07-20Add Counter and Mirror Coat bugfixHyperdriveguy
2018-07-18Fix usage of NUM_UNOWNmid-kid
2018-07-18Fix misnamed character codesmid-kid
Some character codes were erroneously named after their text command counterparts. This has caused a lot of confusion with naming their functions and with other things. I've also removed the `dict2` macro and expanded the `dict` macro. This really isn't something we should be doing for macros but I can't deny it looks a lot neater than repeated code.
2018-07-18Remove some more address commentsmid-kid
2018-07-18Make proper cmdqueue constantsmid-kid
2018-07-18Fix anim_ret_commandmid-kid
2018-07-16Fewer uses of 'Thing2 - Thing1' for sizeof(Thing)Rangi
2018-07-15More OAM coordinate consistencyRangi
2018-07-13Comments for ToggleMaptileDecorationsRangi
2018-07-11Replace more hex values with constants or decimalRangi
2018-07-10Use more options constantsRangi
2018-07-05TileAnimationPalette → AnimateWaterPaletteRangi
2018-07-04Use TRUE/FALSE for wSaveFileExistsRangi
2018-07-04Miscellaneous reorganization fixesRangi
2018-06-30" " → "┘" + 1Rangi
2018-06-30Use significant values 5, 6, and 7Rangi
2018-06-30No linebreakRangi