summaryrefslogtreecommitdiff
path: root/gflib/sprite.h
diff options
context:
space:
mode:
authorSierra A <6080951+Sierraffinity@users.noreply.github.com>2020-05-04 21:14:57 -0700
committerGitHub <noreply@github.com>2020-05-04 21:14:57 -0700
commit4dd3cc7b7691afb8ecd2e8af8b2ebfa717dd2414 (patch)
tree76cd7fa5a9ed806e19221e8d9a11337355f074f5 /gflib/sprite.h
parentb3b99b52ca978104ebed318f1d238fc97892836a (diff)
parenta1244aa5dd4c7519ba6c2dcba5796eec2eba1c90 (diff)
Merge pull request #1035 from Sierraffinity/master
Document undefined sprite template behavior
Diffstat (limited to 'gflib/sprite.h')
-rw-r--r--gflib/sprite.h4
1 files changed, 4 insertions, 0 deletions
diff --git a/gflib/sprite.h b/gflib/sprite.h
index 9753837fd..c9ba9585d 100644
--- a/gflib/sprite.h
+++ b/gflib/sprite.h
@@ -182,6 +182,10 @@ struct SpriteTemplate
SpriteCallback callback;
};
+// UB: template pointer is often used to point to temporary storage,
+// then later dereferenced after being freed. Usually this won't
+// be visible in-game, but this is (part of) what causes the item
+// icon palette to flicker when changing items in the bag.
struct Sprite
{
/*0x00*/ struct OamData oam;