summaryrefslogtreecommitdiff
path: root/engine/battle
diff options
context:
space:
mode:
authorRangi <remy.oukaour+rangi42@gmail.com>2020-08-31 10:23:19 -0400
committerRangi <remy.oukaour+rangi42@gmail.com>2020-08-31 10:23:19 -0400
commitbfd9f617c96af851ad4100b752ea967ef8989edc (patch)
tree078f667a596ee500839f21081c2371ade0ec7950 /engine/battle
parent70eac3a1f7a27d5b71b968708f423dbbff6b146c (diff)
Use constants to delineate map types, and factor out more data
Diffstat (limited to 'engine/battle')
-rw-r--r--engine/battle/battle_transitions.asm3
-rw-r--r--engine/battle/wild_encounters.asm2
2 files changed, 1 insertions, 4 deletions
diff --git a/engine/battle/battle_transitions.asm b/engine/battle/battle_transitions.asm
index 98040fa1..3a6db0b5 100644
--- a/engine/battle/battle_transitions.asm
+++ b/engine/battle/battle_transitions.asm
@@ -118,9 +118,6 @@ GetBattleTransitionID_CompareLevels:
ld [wBattleTransitionSpiralDirection], a
ret
-; fails to recognize VICTORY_ROAD_2F, VICTORY_ROAD_3F, all ROCKET_HIDEOUT maps,
-; POKEMON_MANSION_1F, SEAFOAM_ISLANDS_[B1F-B4F], POWER_PLANT, DIGLETTS_CAVE
-; and SILPH_CO_[9-11]F as dungeon maps
GetBattleTransitionID_IsDungeonMap:
ld a, [wCurMap]
ld e, a
diff --git a/engine/battle/wild_encounters.asm b/engine/battle/wild_encounters.asm
index e24f9632..8c9c1529 100644
--- a/engine/battle/wild_encounters.asm
+++ b/engine/battle/wild_encounters.asm
@@ -39,7 +39,7 @@ TryDoWildEncounter:
; so long as the map is "indoor" and has wild pokemon defined.
; ...as long as it's not Viridian Forest or Safari Zone.
ld a, [wCurMap]
- cp REDS_HOUSE_1F ; is this an indoor map?
+ cp FIRST_INDOOR_MAP ; is this an indoor map?
jr c, .CantEncounter2
ld a, [wCurMapTileset]
cp FOREST ; Viridian Forest/Safari Zone