summaryrefslogtreecommitdiff
path: root/engine/battle_anims/anim_commands.asm
AgeCommit message (Collapse)Author
2021-03-11Verify script command table sizesRangi
2021-02-05Identify some more labelsRangi
2020-11-09Replace $0 with 0 for "ld l, a / ld h, 0" idiomRangi
2020-11-09Identify wBattleAnimTemp0-3Rangi
2020-10-26Use more assertions to ensure correct code and dataRangi
2020-10-26Comment, remove, or revise many unreferenced labelsRangi
2020-10-06 Identify battle bg effects functions and constants (#773)7Soul
Identify battle bg effects functions and constants
2020-10-05Identify more unnamed labelsRangi
2020-08-27Fix some constants surrounding sprite animationsmid-kid
Also commented the use of the field surrounding the struct initialization functions. SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1 SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2 SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3 SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4 BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1 BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
2020-08-05Use TRUE for hCGBPalUpdatemid-kid
2020-07-08Eliminate enum: use const instead, with case-by-case parallel const ↵Rangi
implementations
2020-06-21Replace "Unreferenced" labels with "; unreferenced" commentsRangi
2020-06-17Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to ↵Rangi
OpenSRAM) To do: engine/{menus, overworld}
2020-06-16Harmonize engine/{battle, battle_anims, events, games} with pokegoldRangi
2020-03-21rgbds supports 'X - 1' instead of 'X + -1'Rangi
2020-03-21Miscellaneous fixes from #694Rangi
2020-02-28'and BANK' -> 'aka BANK'Rangi
2019-04-12Create some battle tower SRAM labelsmid-kid
2019-02-16Standardize on $ff ^ X for bitwise negating 8-bit valuesRangi
2019-02-16Document the BattleAnimCmd_ClearObjs bugRangi
2019-02-16Document wBattleAnimFlagsmid-kid
`anim_clearsprites` was misnamed, so I renamed it to `anim_keepsprites`, and documented it in docs/battle_anim_commands.md
2019-02-16Add more constants for battle anim structsmid-kid
Any access of the wram arrays for battle anim objects and background effects use appropriate macros and constants, now.
2019-02-15Anotate more of the battle anim subsystemmid-kid
The X and Y flip flags can be applied through the stack consisting of: - Object attributes - Animation frame attributes - OAM Data Each of these negate eachother. Confused yet? The same stack is traversed to obtain the final tile ID, with an added layer on top for the base GFX offset and the offset for the dynamically loaded GFX requested by the object! wBattleAnimDelay is populated with the values passed to `anim_wait`.
2019-02-06BATTLEANIMSTRUCT_0B -> BATTLEANIMSTRUCT_PARAMmid-kid
This structure member is used for storing the parameter passed to `anim_obj`.
2018-12-26Fix comments around BANK() statementsmid-kid
Found a couple BANK()s that reference multiple labels.
2018-11-25Rename "feet and head follow" commandsmid-kid
The lot of these were rather misnamed, since they're used to replace part of the player or enemy with objects for several background effects. https://github.com/pret/pokecrystal/pull/578#issuecomment-440996244
2018-11-22Identified another user of wBattleAnimTempmid-kid
QueueBattleAnimation loads an object using these wram addresses. Usually populated by the anim_obj command, but in a couple of cases also manually.
2018-11-21Define ANIM_GFX for PLAYER and ENEMYmid-kid
These are used where the head or the feet of the player/enemy have to be moved in an animation, and shouldn't overlap. These aren't actual GFX and should be loaded with the proper commands, and they're always loaded at the end of the VRAM area. Furthermore, I've defined BATTLEANIM_BASE_TILE, which is the tile from which battle animation graphics may start to load. This value was picked to make sure at least an entire pokemon pic fits in the area before it, even though it doesn't seem very used...
2018-08-25Use labels instead of constants for HRAMRangi
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-07-18Fix anim_ret_commandmid-kid
2018-06-25No space between labels and bodiesRangi
2018-06-24Fix triple newlines left over from removing address commentsRangi
2018-06-24Remove all address commentsmid-kid
2018-06-12Note which labels are only needed for locating banks (relevant to issue #485)Rangi
2018-04-05Fix some uses of EFFECTIVEmid-kid
2018-02-03Merge branch 'master' of https://github.com/pret/pokecrystalRangi
# Conflicts: # audio/engine.asm # constants/gfx_constants.asm # constants/map_data_constants.asm # constants/pokemon_data_constants.asm # constants/sprite_constants.asm # constants/wram_constants.asm # data/maps/data.asm # engine/battle/ai/scoring.asm # engine/battle/core.asm # engine/battle/effect_commands.asm # engine/battle/misc.asm # engine/battle_anims/getpokeballwobble.asm # engine/breeding.asm # engine/buy_sell_toss.asm # engine/decorations.asm # engine/events/battle_tower/battle_tower.asm # engine/events/battle_tower/rules.asm # engine/events/buena.asm # engine/events/bug_contest/contest_2.asm # engine/events/daycare.asm # engine/events/dratini.asm # engine/events/halloffame.asm # engine/events/happiness_egg.asm # engine/events/kurt.asm # engine/events/lucky_number.asm # engine/events/magnet_train.asm # engine/events/overworld.asm # engine/events/pokerus/pokerus.asm # engine/events/print_unown.asm # engine/events/print_unown_2.asm # engine/events/unown_walls.asm # engine/item_effects.asm # engine/link.asm # engine/mon_menu.asm # engine/player_object.asm # engine/routines/playslowcry.asm # engine/scripting.asm # engine/search.asm # engine/search2.asm # engine/specials.asm # engine/start_menu.asm # engine/timeset.asm # home/battle_vars.asm # home/map.asm # maps/GoldenrodUndergroundSwitchRoomEntrances.asm # maps/IlexForest.asm # maps/KrissHouse2F.asm # maps/Route39Barn.asm # mobile/mobile_12_2.asm # mobile/mobile_40.asm # mobile/mobile_5f.asm # wram.asm
2018-02-02use "x + -1" not "x +- 1"Rangi
(TODO: use "x - 1" once rgbds allows it)
2018-01-30wSpritesEnd -> wVirtualOAMEnd.luckytyphlosion
2018-01-30Fix wVirtualOAM labels, part 2.luckytyphlosion
2018-01-23Prefix wram labels with w, part 2.luckytyphlosion
2018-01-23Prefix wram labels with w, part 1.luckytyphlosion
Handle edge cases first.
2018-01-16"CryHeader" → "Cry"; "Cry" → "MonCry"Remy Oukaour
2018-01-16Avoid "+- 1" at every maskbitsRemy Oukaour
2018-01-16Remove Predef_ prefix from routines listed in PredefPointersRemy Oukaour
2018-01-14Merge branch 'dev' of https://github.com/TheMostCuriousThing/pokecrystal ↵Remy Oukaour
(resolve PR #460) # Conflicts: # engine/battle/core.asm # engine/save.asm
2018-01-14Merge branch 'master' of https://github.com/xCrystal/pokecrystal (resolve PR ↵Remy Oukaour
#459) # Conflicts: # data/items/descriptions.asm # data/sprite_anims/framesets.asm # engine/crystal_colors.asm # engine/events/kurt.asm # engine/events/special.asm # engine/events/std_scripts.asm # engine/events_3.asm # engine/item_effects.asm # engine/namingscreen.asm # engine/scripting.asm # engine/stats_screen.asm # engine/trade_animation.asm # home/audio.asm # main.asm # maps/BattleTower1F.asm # maps/BattleTowerBattleRoom.asm # maps/BurnedTowerB1F.asm # maps/ElmsLab.asm # maps/GoldenrodDeptStore5F.asm # maps/GoldenrodUnderground.asm # maps/HallOfFame.asm # maps/MahoganyTown.asm # maps/ManiasHouse.asm # maps/MobileBattleRoom.asm # maps/MobileTradeRoomMobile.asm # maps/RadioTower2F.asm # maps/Route35NationalParkGate.asm # maps/Route36NationalParkGate.asm # maps/Route39Farmhouse.asm # tilesets/palette_maps.asm
2018-01-14GFX tile sizes in decimalRemy Oukaour
2018-01-11Use maskbits some moreRemy Oukaour
2018-01-10Resolve #461Remy Oukaour
2018-01-08Simplify comments per Rangi's rec.Adelaide Walter